Delete idea of "accumulation" from metrics SDK #5154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics SDK has an unnecessary level of abstraction called "accumulation". When metrics are collected, we:
An accumulation is essentially a PointData without attributes, or start / end time. We can get rid of accumulation by adjusting
AggregatorHandle
to return PointData instead. In doing so we reduce complexity and allocations.This is a pretty invasive change, since it requires changing method signatures to pass around
startEpochNanos
andepochNanos
where not previously needed. To do it right, I also needed to change the vocabulary of the SDK, renaming any references to accumulation in method names or variables to more appropriate names.Its cumbersome to review, but is a strict refactor so can lean on the tests. It will ultimately make the metrics SDK easier to understand / maintain and more performant, so I do think it's a worthwhile addition.